review request

OpenDreamProject · Jan 1, 2024 · 7155fdc · 7155fdc
1 parent 6bb5dfd
commit 7155fdc
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/DMCompiler/Compiler/DM/DMParser.cs b/DMCompiler/Compiler/DM/DMParser.cs
@@ -1069,7 +1069,7 @@ private DMASTProcStatementSet[] ProcSetEnd(bool allowMultiple) {
                     Error("Expected a condition");
                 }
                 if (condition is DMASTAssign) {
-                    DMCompiler.Emit(WarningCode.AssignmentInConditional, Current().Location, "Assignment in conditional");
+                    DMCompiler.Emit(WarningCode.AssignmentInConditional, condition.Location, "Assignment in conditional");
                 }
                 BracketWhitespace();
                 ConsumeRightParenthesis();
@@ -1382,9 +1382,6 @@ public DMASTProcStatementSwitch.SwitchCase[] SwitchInner() {
 
                         break;
                     }
-                    if (expression is DMASTAssign) {
-                        DMCompiler.Emit(WarningCode.AssignmentInConditional, Current().Location, "Assignment in conditional");
-                    }
 
                     if (Check(TokenType.DM_To)) {
                         Whitespace();