remove pointless stringbuilder operations

OpenDreamProject · Jan 27, 2025 · 55431e4 · 55431e4
1 parent 730862b
commit 55431e4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/Content.Tests/DMProject/Tests/Expression/String/raw3.dm b/Content.Tests/DMProject/Tests/Expression/String/raw3.dm
@@ -0,0 +1,7 @@
+
+//# issue 380
+
+/proc/RunTest()
+	var/a = @(ZZQ)
+asdfZZQ
+	ASSERT(a == "asdf")
diff --git a/DMCompiler/Compiler/DMPreprocessor/DMPreprocessorLexer.cs b/DMCompiler/Compiler/DMPreprocessor/DMPreprocessorLexer.cs
@@ -348,8 +348,7 @@ public Token NextToken(bool ignoreWhitespace = false) {
                         if (GetCurrent() == complexDelimiter[delimIdx]) delimIdx++;
                         else delimIdx = 0;
 
-                        if (delimIdx + 1 == complexDelimiter.Length && c == complexDelimiter[^1]) { // latter check ensures a 1-char delimiter actually matches
-                            TokenTextBuilder.Remove(TokenTextBuilder.Length - delimIdx, complexDelimiter.Length - 1);
+                        if (delimIdx == complexDelimiter.Length && c == complexDelimiter[^1]) { // latter check ensures a 1-char delimiter actually matches
                             break;
                         }
 
@@ -360,8 +359,6 @@ public Token NextToken(bool ignoreWhitespace = false) {
                         _compiler.Emit(WarningCode.BadExpression, startLoc,
                             "Unterminated string delimiter");
                     }
-
-                    TokenTextBuilder.Append(complexDelimiter);
                 } else if (isLong) {
                     bool nextCharCanTerm = false;
 
@@ -395,8 +392,7 @@ public Token NextToken(bool ignoreWhitespace = false) {
                     }
                 }
 
-                if (isComplex) Advance();
-                else TokenTextBuilder.Append(c);
+                if (!isComplex) TokenTextBuilder.Append(c);
 
                 if (!HandleLineEnd())
                     Advance();