Merge branch 'master' into bayprocpath

Content.Tests/DMProject/Tests/Typemaker/proc_path_error.dm → Content.Tests/DMProject/Broken Tests/Typemaker/proc_path_error.dm

@@ -1,6 +1,8 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2701
 #pragma InvalidReturnType error
 
+/datum/foo
+
 /datum/proc/meep() as /atom
 	return /atom
 

Content.Tests/DMProject/Tests/Builtins/Matrix/MatrixLint.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2207
 #pragma SuspiciousMatrixCall error
 
 /proc/RunTest()

Content.Tests/DMProject/Tests/Builtins/rgb.dm

@@ -0,0 +1,12 @@
+/proc/RunTest()
+	ASSERT(rgb(255, 255, 255) =="#ffffff")
+	ASSERT(rgb(255, 0, 0) == "#ff0000" )
+	ASSERT(rgb(0, 0, 255) == "#0000ff")
+	ASSERT(rgb(18, 245, 230) == "#12f5e6")
+	ASSERT(rgb(18, 245, 230, 128) == "#12f5e680")
+	ASSERT(rgb(202, 96, 219, space=COLORSPACE_RGB) == "#ca60db")
+	ASSERT(rgb(291.70734, 56.164383, 85.882355, space=COLORSPACE_HSV) == "#ca60db")
+	ASSERT(rgb(291.70734, 63.07692, 61.764706, space=COLORSPACE_HSL) == "#ca60db" )
+
+	ASSERT(rgb(291.70734, 63.07692, 61.764706, 128, COLORSPACE_HSL) == "#ca60db80" )
+	//ASSERT(rgb(291.70734, 68.2215, 55.423534, space=COLORSPACE_HCY) == "#ca60db") // TODO Support HCY

Content.Tests/DMProject/Tests/Call/PointlessParentCall.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2205
 #pragma PointlessParentCall error
 
 /datum/proc/foo()

Content.Tests/DMProject/Tests/Call/RedundantPositionalKey.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2210
 
 #pragma PointlessPositionalArgument error
 

Content.Tests/DMProject/Tests/Const/Const_CycleRefences.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 
 var/const/A = B
 var/const/B = C

Content.Tests/DMProject/Tests/Dereference/DatumIndex.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2304
 #pragma InvalidIndexOperation error
 
 // Indexing a datum (e.g. datum["foo"]) is not valid in BYOND 515.1641+

Content.Tests/DMProject/Tests/Expression/Constants/resource_not_exists.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 
 /proc/RunTest()
 	var/resource = 'file_doesnt_exist.txt'

Content.Tests/DMProject/Tests/Expression/Derefs/untyped/ident.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 
 /obj
     var/ele = 2

Content.Tests/DMProject/Tests/Expression/Derefs/untyped/proccall.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /obj
     proc/elefn()

Content.Tests/DMProject/Tests/Indent/inconsistent.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0001
 
 /proc/RunTest()
 	var/test1 = 1

Content.Tests/DMProject/Tests/Indent/inner_root_in_proc.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0001
 
 /obj/proc/p()
     return 5 + 3

Content.Tests/DMProject/Tests/List/readonly1.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 //# issue 702
 

Content.Tests/DMProject/Tests/List/readonly2.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 //# issue 702
 

Content.Tests/DMProject/Tests/List/readonly3.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 //# issue 702
 

Content.Tests/DMProject/Tests/List/readonly4.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 //# issue 702
 

Content.Tests/DMProject/Tests/Operators/In_OrderOfOperationsWarning.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD3204
 
 #pragma AmbiguousInOrder error
 

Content.Tests/DMProject/Tests/Operators/Overloads/list_ops.dm

@@ -0,0 +1,15 @@
+/datum/overloader
+	var/list/L = list()
+
+/datum/overloader/proc/operator[](var/idx)
+	return L[idx]
+
+/datum/overloader/proc/operator[]=(var/idx, var/d)
+	L[idx] = d
+
+/proc/RunTest()
+	var/datum/overloader/O = new()
+	O["A"] = 5
+	O["A"]++
+
+	ASSERT(O["A"] == 6)

Content.Tests/DMProject/Tests/Operators/is_assign_lvalue.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
     var/a = 0

Content.Tests/DMProject/Tests/Operators/is_decl_lvalue.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
     (var/a = 1) = 2

Content.Tests/DMProject/Tests/Operators/scope_proc_pointless.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2209
 #pragma PointlessScopeOperator error
 
 /datum/proc/foo()

Content.Tests/DMProject/Tests/Preprocessor/Pragma/pragma_warning.dm

@@ -1,4 +1,4 @@
-//COMPILE ERROR
+//COMPILE ERROR OD1201
 
 #pragma WarningDirective error
 

Content.Tests/DMProject/Tests/Preprocessor/Variadic/variadic_must_be_last.dm

@@ -1,4 +1,4 @@
-//COMPILE ERROR
+//COMPILE ERROR OD0010
 
 #define DAMN(what...,the...,hockeysticks...) world << list(##what)
 

Content.Tests/DMProject/Tests/Preprocessor/define_var_clash2.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0001
 
 #define A 1
 #define B 1

Content.Tests/DMProject/Tests/Preprocessor/directive_linebreaks1.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 
 #define A 5\
 #define B 6

Content.Tests/DMProject/Tests/Preprocessor/macro_newline_compileerror.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0012
 #define TEST(a,b) a+b
 
 /proc/main()

Content.Tests/DMProject/Tests/Preprocessor/macro_var_clash.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0014
 
 //# issue 389
 

Content.Tests/DMProject/Tests/Preprocessor/multi_arg.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0001
 
 //# issue 14
 

Content.Tests/DMProject/Tests/Preprocessor/nested_comment1.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD1200
 
 /proc/RunTest()
     /*

Content.Tests/DMProject/Tests/Preprocessor/nested_comment3.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD1200
 
 //# issue 465
 

Content.Tests/DMProject/Tests/Preprocessor/whitespace_with_macro_functor.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 // issue OD#846
 
 #define TEST(x) x

Content.Tests/DMProject/Tests/Procs/Arglist/input.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/_input(...)
     return input(arglist(args))

Content.Tests/DMProject/Tests/Procs/Arglist/istype.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/_istype(...)
     return istype(arglist(args))

Content.Tests/DMProject/Tests/Procs/Arglist/locate.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/_locate(...)
     return locate(arglist(args))

Content.Tests/DMProject/Tests/Procs/Arglist/newlist.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/_newlist(...)
     return newlist(arglist(args))

Content.Tests/DMProject/Tests/Procs/var_decl_param.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0001
 
 /proc/novar(a, b)
     return a + b

Content.Tests/DMProject/Tests/SetStatements/unimplemented_with_body.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2800
 
 #pragma UnimplementedAccess error
 

Content.Tests/DMProject/Tests/SetStatements/unimplemented_without_body.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD2800
 
 #pragma UnimplementedAccess error
 

Content.Tests/DMProject/Tests/Special Procs/nameof/nameof_error.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0100
 /proc/RunTest()
 	var/list/L = list(1,2,3)
 	nameof(L[2]) // nameof() isn't valid on a list index

Content.Tests/DMProject/Tests/Statements/Control Flow/empty_blocks.dm

@@ -1,4 +1,4 @@
-//COMPILE ERROR
+//COMPILE ERROR OD3100
 //Test that our pragma for this is working.
 #pragma EmptyBlock error
 /proc/RunTest()

Content.Tests/DMProject/Tests/Statements/Control Flow/empty_proc.dm

@@ -1,4 +1,4 @@
-//COMPILE ERROR
+//COMPILE ERROR OD3101
 //Test that our pragma for this is working.
 #pragma EmptyProc error
 

Content.Tests/DMProject/Tests/Statements/Control Flow/labels_bad_jump.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 //# issue 360
 
 bad:

Content.Tests/DMProject/Tests/Statements/Control Flow/labels_bad_link.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 //# issue 360
 
 /proc/RunTest()

Content.Tests/DMProject/Tests/Statements/Control Flow/labels_order_bad.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0404
 //# issue 360
 
 /proc/RunTest()

Content.Tests/DMProject/Tests/Statements/EmptyBlock.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD3100
 #pragma EmptyBlock error
 
 /proc/RunTest()

Content.Tests/DMProject/Tests/Statements/For/nest_in.dm

@@ -1,8 +1,8 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
 	var/list/l1 = list(1,2,3)
 	var/list/l2 = list(4,5,6)
 	var/out = 0
 	for (var/i in l1 in l2)
-		logi += i
+		out += i

Content.Tests/DMProject/Tests/Statements/For/undeclared_iter_var.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
 	var/c = 0

Content.Tests/DMProject/Tests/Statements/For/var_only_not_decl.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
 	var/i

Content.Tests/DMProject/Tests/Statements/Switch/weird_when_clause_pragma.dm

@@ -1,4 +1,4 @@
-//COMPILE ERROR
+//COMPILE ERROR OD3201
 //test to make sure SuspiciousSwitchCase is working
 
 #pragma SuspiciousSwitchCase error

Content.Tests/DMProject/Tests/Statements/Var Decl/var_decl_expr.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0012
 
 /proc/RunTest()
 	var/a = 0 && var/b = 1

Content.Tests/DMProject/Tests/Stdlib/addtext1.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0013
 
 //# issue 663
 

Content.Tests/DMProject/Tests/Text/EmbeddedExpressionPassesErrors.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
 	var/test1 = "["["a""b"]"]" // 'expected end of embedded statement' from inner interpolation

Content.Tests/DMProject/Tests/Text/EndOfEmbeddedExpression.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /proc/RunTest()
 	var/test1 = "["a""b"]" // expected end of embedded expression

Content.Tests/DMProject/Tests/Text/ExpectedEmbeddedExpression.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0012
 
 /proc/RunTest()
 	var/test1 = "[;]" // expected an expression

Content.Tests/DMProject/Tests/Text/ProperImproper.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0001
 
 /proc/RunTest()
 	var/InvalidProper = "Example \proper"

Content.Tests/DMProject/Tests/Tree/Const/Assign/const_assign1.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 //# issue 535
 

Content.Tests/DMProject/Tests/Tree/Const/Assign/const_assign2.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 /obj
 	/var/const/a = 5

Content.Tests/DMProject/Tests/Tree/Const/Assign/const_assign3.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0501
 
 /proc/RunTest()
 	var/const/a = 7

Content.Tests/DMProject/Tests/Tree/Const/const_fn_badarg1.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0500
 
 /proc/somered()
 	return 127

Content.Tests/DMProject/Tests/Tree/Const/const_fn_badarg2.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0500
 
 /proc/somered()
 	return 127

Content.Tests/DMProject/Tests/Tree/Override/override_const.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0011
 
 /atom/var/a = 5
 /atom/const/a = 4

Content.Tests/DMProject/Tests/Tree/Override/override_global.dm

@@ -1,4 +1,4 @@
-// COMPILE ERROR
+// COMPILE ERROR OD0406
 
 /turf/C = 4
 /datum/var/const/C = 5