Skip to content

fix(chat): keep composer Send button reachable with many attachments #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
craigamcw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chat): keep composer Send button reachable with many attachments #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/components/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@

prevMessageCountRef.current = messageCount;
prevPartialLengthRef.current = partialLength;
}, [messages.length, partialMessage.length, partialThinking.length]);

Check warning on line 214 in src/renderer/components/ChatView.tsx

View workflow job for this annotation

GitHub Actions / Lint & Test 

React Hook useEffect has a missing dependency: 'scrollToBottom'. Either include it or remove the dependency array

// Additional scroll trigger for content height changes (e.g., TodoWrite expand/collapse)
useEffect(() => {
Expand All @@ -232,7 +232,7 @@
return () => {
resizeObserver.disconnect();
};
}, []); // ResizeObserver is stable — no need to recreate on message count changes

Check warning on line 235 in src/renderer/components/ChatView.tsx

View workflow job for this annotation

GitHub Actions / Lint & Test 

React Hook useEffect has a missing dependency: 'scrollToBottom'. Either include it or remove the dependency array

// Cleanup scroll timeouts on unmount
useEffect(() => {
Expand Down Expand Up @@ -732,7 +732,7 @@
>
{/* Image previews */}
{pastedImages.length > 0 && (
<div className="grid grid-cols-2 sm:grid-cols-3 md:grid-cols-4 lg:grid-cols-5 gap-2 mb-3">
<div className="grid grid-cols-2 sm:grid-cols-3 md:grid-cols-4 lg:grid-cols-5 gap-2 mb-3 max-h-[28vh] overflow-y-auto pr-1">
{pastedImages.map((img, index) => (
<div key={img.url || `pasted-image-${index}`} className="relative group">
<img
Expand All @@ -754,7 +754,7 @@

{/* File attachments */}
{attachedFiles.length > 0 && (
<div className="space-y-2 mb-3">
<div className="space-y-2 mb-3 max-h-[22vh] overflow-y-auto pr-1">
{attachedFiles.map((file, index) => (
<div
key={file.path || `attached-file-${index}`}
Expand Down
Loading