Skip to content

fix(i18n): show English Memory settings labels instead of Chinese fallback #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
craigamcw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(i18n): show English Memory settings labels instead of Chinese fallback #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/components/SettingsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
if (!viewedTabs.has(activeTab)) {
setViewedTabs((prev) => new Set([...prev, activeTab]));
}
}, [activeTab]);

Check warning on line 103 in src/renderer/components/SettingsPanel.tsx

View workflow job for this annotation

GitHub Actions / Lint & Test 

React Hook useEffect has a missing dependency: 'viewedTabs'. Either include it or remove the dependency array

const tabs = [
{
Expand Down Expand Up @@ -141,9 +141,9 @@
},
{
id: 'remote' as TabId,
label: t('settings.remote', '远程控制'),
label: t('settings.remote'),
icon: Wifi,
description: t('settings.remoteDesc', '通过飞书等平台远程使用'),
description: t('settings.remoteDesc'),
},
{
id: 'logs' as TabId,
Expand Down
Loading
Loading