fix(deps): bump nanoid to 3.3.18 (Dependabot #17) - #4739
Merged
Conversation
CompleteDotTech
force-pushed
the
fix/cave-dip-nanoid-3-3-18
branch
from
August 19, 2026 20:25
d85a6ef to
ac5a2ef
Compare
nanoid 3.3.17 lets a custom generator loop indefinitely when size is
zero (High). It is not a direct dependency here: postcss@8.4.31 and
postcss@8.5.26 both pull it in, and their ^3.3.x ranges already admit
the patched 3.3.18.
Pin the transitive resolution with a scoped pnpm override
("nanoid@3": "3.3.18") so both postcss copies land on the patched
release and no future resolution can drift back. nanoid@5.1.16 is
unaffected and untouched.
Validated with pnpm install --frozen-lockfile, pnpm lint,
pnpm typecheck, and pnpm build.
CompleteDotTech
force-pushed
the
fix/cave-dip-nanoid-3-3-18
branch
from
August 19, 2026 20:48
ac5a2ef to
51a5dc9
Compare
CompleteDotTech
marked this pull request as ready for review
August 19, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves Dependabot alert #17 (High):
nanoid3.3.17 — custom generators can loop indefinitely when size is zero. Patched in 3.3.18.nanoidis not a direct dependency.pnpm-lock.yamlcarried two copies:nanoid@3.3.17— vulnerable, pulled in transitively bypostcssnanoid@5.1.16— unaffected, untouchedpostcss declares a
^3.3.xrange, so 3.3.18 is already admissible. A scoped pnpm override ("nanoid@3": "3.3.18") pins the transitive resolution so it lands on the patched release and no future resolution drifts back. The existing overrides are left intact.Change
package.json"nanoid@3": "3.3.18"added topnpm.overridespnpm-lock.yamloverridesentry, thenanoid@3.3.17→3.3.18package + snapshot entries, and thepostcss@8.5.26snapshot referenceTotal: 6 insertions, 4 deletions across 2 files. No unrelated lockfile churn.
Rebased onto current
mainafter the sibling dependency PRs (#4741 postcss, #4742 sharp, #4737 serde_with) landed. That rebase collapsed the secondpostcss@8.4.31copy intopostcss@8.5.26, so only one postcss snapshot reference remains to update.Validation
Run from a clean checkout of this branch at
51a5dc9:pnpm install --frozen-lockfile— passes (lockfile consistent withpackage.json)pnpm lint— passes (design codemod check: 0 files with drift; eslint--max-warnings=0clean)pnpm typecheck— passes (tsc --noEmit, no errors)pnpm build— passes, including thebundle-budgetandstandalone-budgetpostbuild gatesgrep -n "nanoid" pnpm-lock.yaml— no3.3.17anywhere;nanoid@3: 3.3.18inoverrides,nanoid@3.3.18in packages + snapshots, the postcss snapshot on3.3.18node -e "require('./node_modules/.pnpm/postcss@8.5.26/node_modules/nanoid/package.json').version"→3.3.18in the installed treeCI on this head is fully green across all ten jobs, including the required
Frontend build(Playwright: 282 passed, 3 skipped).