Skip to content

test(onboarding): exercise keyboard focus visibility#3930

Merged
BunsDev merged 6 commits into
mainfrom
fix/setup-focus-review-followup
Jul 26, 2026
Merged

test(onboarding): exercise keyboard focus visibility#3930
BunsDev merged 6 commits into
mainfrom
fix/setup-focus-review-followup

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 26, 2026

Copy link
Copy Markdown
Member

Summary

  • drive the setup header focus assertion through a real keyboard Tab transition
  • keep the setup-action source contract order-insensitive while preserving every required layout class
  • follow up the two Copilot review threads on Simplify setup page chrome #3913 after that PR merged

Verification

  • node src/components/onboarding-polish.test.ts
  • pnpm exec playwright test tests/onboarding-wizard.spec.ts --grep "keeps setup-header focus indicators" --project=desktop --no-deps --workers=1 --reporter=line
  • pnpm typecheck
  • pnpm lint
  • pnpm check:tests-wired
  • git diff --check

Copilot AI review requested due to automatic review settings July 26, 2026 20:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens onboarding focus-indicator coverage by making the Playwright assertion exercise a real keyboard Tab transition (to trigger :focus-visible), and updates the setup-header source-contract test to be resilient to harmless Tailwind class reordering while still enforcing the required layout classes.

Changes:

  • Update the onboarding wizard Playwright spec to reach the “Re-check” button via Tab (keyboard modality) instead of programmatic .focus().
  • Make the setup-header contract test order-insensitive by checking for required classes individually rather than matching the full className string.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/onboarding-wizard.spec.ts Uses a keyboard Tab transition to verify :focus-visible behavior for the setup header action buttons.
src/components/onboarding-polish.test.ts Switches the setup-header contract from a full-string regex to per-class inclusion checks (order-insensitive).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/onboarding-polish.test.ts Outdated
@BunsDev
BunsDev merged commit 1778261 into main Jul 26, 2026
15 checks passed
@BunsDev
BunsDev deleted the fix/setup-focus-review-followup branch July 26, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants