test(onboarding): exercise keyboard focus visibility#3930
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens onboarding focus-indicator coverage by making the Playwright assertion exercise a real keyboard Tab transition (to trigger :focus-visible), and updates the setup-header source-contract test to be resilient to harmless Tailwind class reordering while still enforcing the required layout classes.
Changes:
- Update the onboarding wizard Playwright spec to reach the “Re-check” button via
Tab(keyboard modality) instead of programmatic.focus(). - Make the setup-header contract test order-insensitive by checking for required classes individually rather than matching the full
classNamestring.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/onboarding-wizard.spec.ts | Uses a keyboard Tab transition to verify :focus-visible behavior for the setup header action buttons. |
| src/components/onboarding-polish.test.ts | Switches the setup-header contract from a full-string regex to per-class inclusion checks (order-insensitive). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
node src/components/onboarding-polish.test.tspnpm exec playwright test tests/onboarding-wizard.spec.ts --grep "keeps setup-header focus indicators" --project=desktop --no-deps --workers=1 --reporter=linepnpm typecheckpnpm lintpnpm check:tests-wiredgit diff --check