Skip to content

fix(updater): quote MSI log argument once#3819

Merged
CompleteDotTech merged 1 commit into
mainfrom
fix/windows-msi-updater-log-quoting
Jul 25, 2026
Merged

fix(updater): quote MSI log argument once#3819
CompleteDotTech merged 1 commit into
mainfrom
fix/windows-msi-updater-log-quoting

Conversation

@CompleteDotTech

Copy link
Copy Markdown
Member

Summary

  • centralize Windows MSI verbose-log argument construction
  • preserve exactly one pair of quotes around the log-file path because tauri-plugin-updater 2.10.1 joins installer arguments into the raw ShellExecuteW parameter string
  • add a regression test for a spaced log path that rejects missing or doubled quoting

Root cause

The updater receives installer_args as raw command-line segments, not process arguments. The log path must be quoted once in the final msiexec parameter string so /L*V treats a path containing spaces as one argument. The previous inline formatting left this dependency contract implicit and untested.

Validation

  • rustfmt --edition 2021 --check src/tauri_setup.rs
  • cargo test msi_verbose_log_path_is_quoted_once_in_shell_execute_parameters --lib
  • cargo check
  • cargo test --lib (70 passed)

cargo fmt --check still reports pre-existing formatting drift in unrelated Rust files.

Follow-up

Closes #3811. Tracks bead cave-u6ps.

Real Windows hardware update verification remains required before merge: confirm that msi-upgrade-from-<version>-<pid>.log is created and contains verbose MSI output during an upgrade.

@CompleteDotTech
CompleteDotTech force-pushed the fix/windows-msi-updater-log-quoting branch from 08b443a to 02d7e42 Compare July 25, 2026 03:35
@CompleteDotTech
CompleteDotTech merged commit 0c67011 into main Jul 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-msi: verify msiexec /L*V installer_args quoting produces a log

1 participant