fix(updater): quote MSI log argument once#3819
Merged
Merged
Conversation
CompleteDotTech
force-pushed
the
fix/windows-msi-updater-log-quoting
branch
from
July 25, 2026 03:35
08b443a to
02d7e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tauri-plugin-updater2.10.1 joins installer arguments into the rawShellExecuteWparameter stringRoot cause
The updater receives
installer_argsas raw command-line segments, not process arguments. The log path must be quoted once in the finalmsiexecparameter string so/L*Vtreats a path containing spaces as one argument. The previous inline formatting left this dependency contract implicit and untested.Validation
rustfmt --edition 2021 --check src/tauri_setup.rscargo test msi_verbose_log_path_is_quoted_once_in_shell_execute_parameters --libcargo checkcargo test --lib(70 passed)cargo fmt --checkstill reports pre-existing formatting drift in unrelated Rust files.Follow-up
Closes #3811. Tracks bead
cave-u6ps.Real Windows hardware update verification remains required before merge: confirm that
msi-upgrade-from-<version>-<pid>.logis created and contains verbose MSI output during an upgrade.