fix(oss): prevent cloud menu startup crashes - #225
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents OSS macOS startup crashes during menu construction by ensuring hosted/cloud-only menu items are not created when cloud services are unavailable, and adds regressions to keep this boundary from drifting.
Changes:
- Gate Drive/referral/shared-blocks/Drive-toggle menu items behind
ChannelState::cloud_services_available()in macOS menu construction. - Add a macOS-only integration regression test that boots the app under
Channel::Ossand asserts the root view initializes. - Add public-surface tests that verify cloud-only menu items remain properly gated.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/integration/tests/integration/ui_tests.rs | Registers the new macOS-only OSS startup regression in the UI integration suite. |
| crates/integration/src/test/app_startup.rs | Introduces test_oss_app_menu_startup asserting the root view exists after startup. |
| crates/integration/src/test.rs | Wires the new startup test module and re-exports it (macOS-only). |
| crates/integration/src/bin/integration.rs | Runs the new startup test under Channel::Oss; registers the test in the runner (macOS-only). |
| app/src/castcodes_public_surface_tests.rs | Adds source-based tests asserting specific menu items are gated behind cloud availability. |
| app/src/app_menus.rs | Implements the cloud-availability gating to avoid constructing unavailable hosted-only menu actions on OSS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BunsDev
force-pushed
the
fix/oss-referral-menu-crash
branch
from
July 26, 2026 15:12
8685029 to
52f3e13
Compare
BunsDev
force-pushed
the
fix/oss-referral-menu-crash
branch
from
July 26, 2026 15:24
52f3e13 to
8ccc8d7
Compare
Signed-off-by: Val Alexander <68980965+BunsDev@users.noreply.github.com>
BunsDev
force-pushed
the
fix/oss-referral-menu-crash
branch
from
July 27, 2026 06:08
8ccc8d7 to
c724507
Compare
BunsDev
marked this pull request as ready for review
July 27, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Channel::Ossand verifies the root view initializes.The original crash occurred during menu construction with
action should have a name: ReferAFriend; exposing that item also revealed the same unavailable-binding boundary forToggleWarpDrive.Linked Issue
Closes #226
ready-to-implement.Channel::Ossstartup integration, and focused source assertions cover the failure boundary.Testing
./script/run..applaunch remained running for more than 30 seconds and produced no new macOS crash diagnostic../script/check_ai_attribution./script/check_rebrand./script/presubmit(format, workspace and completer Clippy, clang-format, WGSL, PSScriptAnalyzer, 6,559/6,559 workspace tests, 107/107 completer tests, and doc tests passed)cargo test -p warp-app --features gui --lib castcodes_public_surface_tests:: -- --nocapture(4 passed)cargo run -p integration --bin integration -- test_oss_app_menu_startup(passed)Agent Mode
CHANGELOG-BUG-FIX: Fixed OSS macOS startup crashes caused by unavailable hosted menu actions.