Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] remove hardcoded first value in list method when using getAll #810

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

axelfahy
Copy link
Contributor

@axelfahy axelfahy commented Jan 17, 2025

Currently, when listing entities with the getAll parameter, the first value is overwritten. This PR removes the overwrite of the first value when using getAll in list methods, for all entities.

Proposed changes

  • Remove the hardcoding of the first value when using getAll in list methods for all entities.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

PR #796 did not fix this related issue.

FYI, the following entities did not use getAll and it the variable has been removed:

  • pycti/entities/opencti_kill_chain_phase.py
  • pycti/entities/opencti_location.py
  • pycti/entities/opencti_marking_definition.py
  • pycti/entities/opencti_observed_data.py
  • pycti/entities/opencti_stix_nested_ref_relationship.py
  • pycti/entities/opencti_threat_actor.py
  • pycti/entities/opencti_threat_actor_group.py
  • pycti/entities/opencti_threat_actor_individual.py

@axelfahy axelfahy force-pushed the fix/first-value-in-list branch from 5ba6321 to ed069d7 Compare January 17, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant