Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove harcoded first value when getting all indicators #796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jorgeacjitx
Copy link

Proposed changes

  • The page size listing all indicators with the "getAll" param was hardcoded to 100. To increase performance, this restriction is proposed to be removed.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yassine-ouaamou
Copy link
Member

Hi @jorgeacjitx,
Thanks for your contribution. Can you fix the formatting of you code using "black"?

@jorgeacjitx
Copy link
Author

jorgeacjitx commented Dec 11, 2024

Hi @jorgeacjitx, Thanks for your contribution. Can you fix the formatting of you code using "black"?

Yes, @yassine-ouaamou the problem is that the pre-commit hook is reformatting my code again. I just skipped the pre-commit hook and now the formatting looks good. Please look at the formatting pre-commit hook because it's not working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants