Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client] Fix stix core objects list graphql query (#491) #492

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[client] Fix stix core objects list graphql query (#491) #492

merged 1 commit into from
Nov 15, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Nov 14, 2023 •
edited
Loading

Proposed changes

  • Set the right type for $elementId param : [String]

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Nov 14, 2023
@SouadHadjiat SouadHadjiat linked an issue Nov 14, 2023 that may be closed by this pull request
Graphql error with elementId when listing stix core objects #491
Closed
@SouadHadjiat SouadHadjiat marked this pull request as ready for review November 14, 2023 13:30
@SouadHadjiat SouadHadjiat mentioned this pull request Nov 14, 2023
Closed
@yassine-ouaamou
Copy link
Member

Tested in different cases and all is good 👍

@yassine-ouaamou yassine-ouaamou self-requested a review November 15, 2023 08:29
@SouadHadjiat SouadHadjiat merged commit e7893f4 into master Nov 15, 2023
2 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/491 branch November 15, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassine-ouaamou yassine-ouaamou yassine-ouaamou approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphql error with elementId when listing stix core objects
2 participants
@SouadHadjiat @yassine-ouaamou