fix: Opaal not included in bootstrap or cert update #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opaal was not included in the certificate update, there is a place where opaal is used and needs the update FQDN and IP Signed-off-by: Travis Powell <[email protected]>
Contributor
|
Thanks. Has this been tested? |
Signed-off-by: Travis Powell <[email protected]>
Signed-off-by: Travis Powell <[email protected]>
Updated the path to the opaal.container file, was pointed at openchami/config instad of containers/systemd Signed-off-by: Travis Powell <[email protected]>
Contributor
Author
|
The opaal sed had a mis-configuration, it has now been updated to the right path to the container file. |
Signed-off-by: Travis Powell <[email protected]>
Signed-off-by: Travis Powell <[email protected]>
synackd
requested changes
Jul 14, 2025
synackd
reviewed
Jul 14, 2025
Signed-off-by: Travis Powell <[email protected]>
Signed-off-by: Travis Powell <[email protected]>
synackd
requested changes
Jul 16, 2025
Contributor
synackd
left a comment
synackd
left a comment
There was a problem hiding this comment.
Just a couple of things, but I think after these this is ready to merge.
Signed-off-by: Travis Powell <[email protected]>
Signed-off-by: Travis Powell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opaal was not included in the certificate update, there is a place where opaal is used and needs the update FQDN and IP