-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONNECT_CMD option for interfaces #1886
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
==========================================
- Coverage 79.46% 79.42% -0.05%
==========================================
Files 523 523
Lines 40910 40926 +16
==========================================
- Hits 32510 32506 -4
- Misses 8400 8420 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation for PERIODIC_CMD in addition to CONNECT_CMD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the super() calls in connect is breaking. That is what resets protocols and needs to happen before the "interface is connected" and the first commands are sent.
Maybe add a new connect_hook method that is called by interface_microservice after .connect succeeds?
|
closes #1365