Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONNECT_CMD option for interfaces #1886

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Add CONNECT_CMD option for interfaces #1886

merged 7 commits into from
Feb 13, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 9, 2025

closes #1365

@jmthomas jmthomas requested a review from ryanmelt February 9, 2025 04:58
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.42%. Comparing base (7e651f5) to head (85c6e91).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
- Coverage   79.46%   79.42%   -0.05%     
==========================================
  Files         523      523              
  Lines       40910    40926      +16     
==========================================
- Hits        32510    32506       -4     
- Misses       8400     8420      +20     
Flag Coverage Δ
python 83.96% <ø> (-0.12%) ⬇️
ruby-api 48.45% <ø> (ø)
ruby-backend 82.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added documentation for PERIODIC_CMD in addition to CONNECT_CMD

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the super() calls in connect is breaking. That is what resets protocols and needs to happen before the "interface is connected" and the first commands are sent.

Maybe add a new connect_hook method that is called by interface_microservice after .connect succeeds?

@jmthomas jmthomas merged commit d9b0bda into main Feb 13, 2025
18 of 19 checks passed
@jmthomas jmthomas deleted the connect_cmd branch February 13, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add standard interface OPTION to send command(s) at connect
2 participants