Fix import-map-overrides dialog style #1880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They changed to putting everything in the shadow DOM, which means we can't style it directly from our stylesheets anymore. Dialog text was unreadable due to it using the default
color: canvastext;
from the user-agent sheet for dialogs, which isrgb(255,255,255)
. I think their demo still works because of differing themes.Before:
![image](https://private-user-images.githubusercontent.com/44932063/410702116-e0955714-9e9c-4447-86eb-863bde4aee16.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTY0MDgsIm5iZiI6MTczODk5NjEwOCwicGF0aCI6Ii80NDkzMjA2My80MTA3MDIxMTYtZTA5NTU3MTQtOWU5Yy00NDQ3LTg2ZWItODYzYmRlNGFlZTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA2MjgyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYyM2M3Y2VlZWNiYzc5Nzg3YmM2N2UxYjU3NWNmNDkxMjliMWJhOTMzMjhlZGJkNGQ5MGNlM2ZhNmRhNjgyYzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AMV6_EEwm4RP-TbSi7tkD3C_yGJ8RXBd_WjYo7mynq4)
After:
![image](https://private-user-images.githubusercontent.com/44932063/410702173-68c52a26-bad8-4729-9fb1-18f2ee54a86f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTY0MDgsIm5iZiI6MTczODk5NjEwOCwicGF0aCI6Ii80NDkzMjA2My80MTA3MDIxNzMtNjhjNTJhMjYtYmFkOC00NzI5LTlmYjEtMThmMmVlNTRhODZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA2MjgyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWExMGE4MGQyNmFmOTViOTBiZWVkMWYyMTkzYTdlYzgzYWRiNGYzZjI4ZjU1ZGI4NGRmNmQwODdhZWNmNTA1NzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qXay9sVDzeIbfF3CLqdEfvRu4Yj6fHvZRn7rZsRNeWo)