Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import-map-overrides dialog style #1880

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

ryan-pratt
Copy link
Contributor

They changed to putting everything in the shadow DOM, which means we can't style it directly from our stylesheets anymore. Dialog text was unreadable due to it using the default color: canvastext; from the user-agent sheet for dialogs, which is rgb(255,255,255). I think their demo still works because of differing themes.

Before:
image

After:
image

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (48a3666) to head (ad965bd).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   79.40%   79.40%   -0.01%     
==========================================
  Files         523      523              
  Lines       40905    40905              
==========================================
- Hits        32482    32479       -3     
- Misses       8423     8426       +3     
Flag Coverage Δ
python 83.97% <ø> (-0.03%) ⬇️
ruby-api 48.45% <ø> (ø)
ruby-backend 82.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryan-pratt ryan-pratt merged commit 7b95638 into main Feb 7, 2025
28 of 30 checks passed
@ryan-pratt ryan-pratt deleted the bug/imo-dialog-style branch February 7, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants