Add command description to hazardous dialog #1879
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
==========================================
- Coverage 79.40% 79.40% -0.01%
==========================================
Files 523 523
Lines 40905 40905
==========================================
- Hits 32482 32481 -1
- Misses 8423 8424 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| <v-col :cols="colSize" :class="{ 'openc3-yellow': hazardous }"> | ||
| Description: {{ description }} | ||
| <template v-if="hazardous"> (HAZARDOUS) </template> | ||
| </v-col> |
There was a problem hiding this comment.
What was the reason for this change? I thought this would always color the description as yellow and I actually ran it to prove it didn't. I don't think I've used this technique to set a class before.
There was a problem hiding this comment.
Just removing a tiny bit of code duplication. This reads quite a bit nicer imo, and I just ended up here while trying to figure out how to get a command's description.
We do this a few other places, for example here
Closes #1870