Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure target_file returns utf-8 files #1853

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Ensure target_file returns utf-8 files #1853

merged 5 commits into from
Jan 24, 2025

Conversation

jmthomas
Copy link
Member

closes #1793

@jmthomas jmthomas marked this pull request as ready for review January 20, 2025 20:08
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (fb1a8ad) to head (8593dc7).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/utilities/target_file.rb 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   79.57%   79.54%   -0.03%     
==========================================
  Files         519      519              
  Lines       40774    40796      +22     
==========================================
+ Hits        32447    32453       +6     
- Misses       8327     8343      +16     
Flag Coverage Δ
python 84.24% <ø> (-0.08%) ⬇️
ruby-api 48.72% <ø> (ø)
ruby-backend 82.57% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

openc3/lib/openc3/utilities/target_file.rb Outdated Show resolved Hide resolved
openc3/lib/openc3/utilities/target_file.rb Outdated Show resolved Hide resolved
@jmthomas jmthomas requested a review from ryanmelt January 22, 2025 04:59
@ryanmelt ryanmelt merged commit 96e0625 into main Jan 24, 2025
28 checks passed
@ryanmelt ryanmelt deleted the ensure_utf8 branch January 24, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open long edited suite, AXIOS error
2 participants