Fix previous chat momentarily showing when opening from notification#220
Open
leoforney wants to merge 2 commits into
Open
Fix previous chat momentarily showing when opening from notification#220leoforney wants to merge 2 commits into
leoforney wants to merge 2 commits into
Conversation
…reezes - Updated build.gradle NDK version to r28 and minSdk to 28 for 16kb ELF alignment - Upgraded rust openssl and patched cargokit bash scripts for environment propagation - Refactored ui_helpers clip() to use compute isolate for image processing - Optimized ChatsService updateShareTarget to prevent spam on every text edit - Fixed ChatLifecycleManager synchronous ObjectBox relation loading stall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that when clicking a notification to open a conversation, the app doesn't briefly display the previously opened chat before navigating to the new intent.
Previously, this brief flash would often accidentally mark unread messages in the older chat as read. This is resolved by checking if there's an active chat currently open; if so, we clear the navigation stack (
popUntil((route) => route.isFirst)) to ensure the view is empty before proceeding with the transition to the new chat.