Changes logic to handle both upper and lower case on all dispute mess… #1834
Conversation
…ages from the server. - this was already done in some cases, now it's done everywhere - TODO: investigate if the previous instances of handling upper and lower cases were because the server was inconsistent. If that's the case, the server should be updated to always use the same case.
| @@ -13,7 +13,7 @@ | |||
| <%= polyglot.t('NotificationOrderConfirmed') %> | |||
| </div> | |||
| <div class="textSize11px floatLeft txt-fade"><%= ob.moment(new Date(ob.timestamp*1000)).locale(window.lang).format('MMM D, h:mm A') %></div> | |||
| <% } else if(ob.type == "dispute_close") { %> | |||
There was a problem hiding this comment.
Same concern as on the other PR. If indeed the server is inconsistently sending types with different case, then the bug should be on the server. IMHO, it's poor practice to complicate a client code base to account for fixable defects in the server.
There was a problem hiding this comment.
I think the server currently only sends upper case, handling lower case was left in because it was there before, and I didn't want to add a new bug in the 1.1.9 release.
| case "dispute_open": | ||
| Backbone.history.navigate('#transactions/purchases/' + this.model.get('order_id'), {trigger: true}); | ||
| break; | ||
| case "dispute_close": |
There was a problem hiding this comment.
In the server ticket, I would also request consistency in format beyond case. For example, some types have underscores for spaces (dispute_close) whereas others use actual spaces (new order).
There was a problem hiding this comment.
That would be good, the messages don't have much consistency.
|
A server issue for the data inconsistency has been posted. OpenBazaar/OpenBazaar-Server#506 |
…ages from the server.