Bug Fix: KeyError and Repeat Counts in evaluation #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'args.evaluate_times' is greater than 1, during the second evaluation, the key 'qid' is initialized, but 'round_i' is not. This leads to a KeyError.
The comparison result has been updated, but the completion status has not. As a result, when loading the JSON file, the 'qids' from this section will be counted repeatedly.
|
Good PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qid已经在prefer_dict里面了，直接进入elif会导致没有"round_1"而报错；reference_model或output_model已经+1了，但没有标记为complete。这样从文件读取再次评估的时候，似乎会重复计算这部分。