-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Java] Support JsonNullable in JaxRS-spec (issue #9018) #22412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Java] Support JsonNullable in JaxRS-spec (issue #9018) #22412
Conversation
c90ae9c to
6dcfadd
Compare
|
thanks for the PR please follow step 3 to update the samples. |
|
Hi @wing328, sorry for missing this. The changes were in all sort of files I did not expect, so I assumed that these were not part of the PR. Now I see that they should've been included. The changes are present because the flag |
|
After running These are most likely not related to my changes. At least, I don't recognize them as such. Should I commit those files? |
|
are you using WSL under Windows to run the command updating samples? |
|
No, I'm using Ubuntu LTS. |
This fixes issue #9018
This is basically just copying the relevant things (the "vendorExtensions.x-is-jackson-optional-nullable" things) from
modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pojo.mustachetomodules/openapi-generator/src/main/resources/JavaJaxRS/spec/pojo.mustache.Mentioning Java technical committee
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfgPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)