-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[JAVA](native-client) Add support for UnaryInterceptors #22381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dschodits-secunet
wants to merge
5
commits into
OpenAPITools:master
Choose a base branch
from
dschodits-secunet:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Nov 23, 2025
| {{/useGzipFeature}} | ||
| import java.util.stream.Collectors; | ||
|
|
||
| {{#useUnaryInterceptor}}import java.util.function.UnaryOperator;{{/useUnaryInterceptor}} |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
{{#useUnaryInterceptor}}import
java.util.function.UnaryOperator;
{{/useUnaryInterceptor}}
to avoid blank lines
wing328
reviewed
Nov 23, 2025
| * | ||
| * <p>This is useful for logging, monitoring or extraction of header variables</p> | ||
| * | ||
| * <p>If you are using the UnaryInterceptor you can even manipulate the response to a certain degree</p> |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about showing this comment only when the option is enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr solves Issue: #22333 by adding Support for UnaryInterceptors in the Java-Native-Client
This is done by adding a new config option called "useUnaryInterceptor" which changes the Datatype of the ResponseInterceptor from a Consumer to a UnaryInterceptor. With a variable reassignment this allows for changing an incomming response before it gets passed.
This change doesn't break any existing Systems due to the default value of false for the "useUnaryInterceptor".
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)