-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[Java] [Spring] Use deduction configOptions for oneOfInterfaces #20919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Java] [Spring] Use deduction configOptions for oneOfInterfaces #20919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small improvements
Merge master
…into useDeductionForOneOfInterfaces # Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
Merge master
Add comment to force rebuild
@martin-mfg thanks for the PR. I've merged your changes and master When this PR is merged by @wing328 I will implement the samedi Deduction mechanism for java client using Jackson |
Fix #20891
Add a new configOption to the spring generator:
useOneOfInterfacesDeduction
When useOneOfInterfaces=true
it allows the generation of an additional annotation on the generated inferface
@JsonTypeInfo(use = JsonTypeInfo.Id.DEDUCTION)
and the necessary @JsonSubTypes
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)