Skip to content

[Java] [Spring] Use deduction configOptions for oneOfInterfaces #20919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jpfinne
Copy link
Contributor

@jpfinne jpfinne commented Mar 18, 2025

Fix #20891

Add a new configOption to the spring generator:
useOneOfInterfacesDeduction

When useOneOfInterfaces=true
it allows the generation of an additional annotation on the generated inferface
@JsonTypeInfo(use = JsonTypeInfo.Id.DEDUCTION)
and the necessary @JsonSubTypes

PR checklist

  • Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

Copy link
Contributor

@martin-mfg martin-mfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpfinne, thanks for the PR! Please merge the 2 fixes I proposed via jpfinne#2. If you want me to explain more in detail which problems are fixed there, let me know. And please solve the merge conflict with master. Then this PR is good to go I think.

jpfinne added 4 commits March 23, 2025 09:51
…into useDeductionForOneOfInterfaces

# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
@jpfinne jpfinne requested a review from martin-mfg March 23, 2025 09:41
Add comment to force rebuild
@jpfinne
Copy link
Contributor Author

jpfinne commented Mar 23, 2025

Hi @jpfinne, thanks for the PR! Please merge the 2 fixes I proposed via jpfinne#2. If you want me to explain more in detail which problems are fixed there, let me know. And please solve the merge conflict with master. Then this PR is good to go I think.

@martin-mfg thanks for the PR.

I've merged your changes and master

When this PR is merged by @wing328 I will implement the samedi Deduction mechanism for java client using Jackson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [JavaSpring] use JsonTypeInfo.Id.DEDUCTION for oneOf interface
2 participants