feat: add folder-grouped tabular review rows - #274
Conversation
95d040e to
5f996cf
Compare
|
Thanks for splitting this out of #54. The idempotent migration with a legacy backfill, the create-path rollback, and the revoke + RLS on the two new tables — matching, even exceeding, the repo's backend-owned-table pattern — are genuinely good work. The core problem is that the feature currently ends at the database. Must-fix:
Smaller: several helpers ignore Supabase errors (a transient failure yields a silently empty review), and adding the two new tables to the stack test's To make this easy to act on I've opened ecarjat#1 against your branch: row-based generation and rendering wired end to end, the tsc errors and migration date fixed, tests added — merge it or cherry-pick. It sits directly on your branch as three focused commits; the rebase onto main (including the |
There was a problem hiding this comment.
Details in my comment below — the schema work is solid, but generation/rendering aren't wired to the new rows yet, the frontend typecheck fails, and the migration needs re-dating. There's a follow-up PR against your branch implementing the fixes.
Summary
Focused replacement for #54, rebased on the current
mainbranch.Changes
Why
Lets a tabular review process all documents in a project subfolder as one logical row without coupling the change to the separate page-limit or PDF.js cleanup work from #54.
Testing
npm test --prefix frontendnpm test --prefix backendnpm run build --prefix backend