Repository navigation
exp369: Analyze default-model conditioning and monomer discrepancies - #371
timodonnell wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @timodonnell's task in 10m 7s —— View job Review complete
🤖 Code reviewNo issues found. Checked for bugs and AGENTS.md compliance. Reviewed commit: What was checkedFour independent Opus reviewers (two on Compliance — clean on the rules in scope:
Correctness — the claims that most needed verifying hold up in the code:
Caveats
--- · Branch |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8042714055
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version = "0.1.0" | ||
| requires-python = ">=3.12,<3.13" | ||
| dependencies = [ | ||
| "biopython>=1.85", |
There was a problem hiding this comment.
Pin the Marin launcher dependency
When the submission or recovery scripts are run from a clean checkout with uv run, their fray and iris imports fail because this dependency list and the committed lock contain none of the Marin launcher stack. The README notes that the completed run relied on a separate task-local checkout at Marin revision af9c6789e8, so the committed environment cannot reproduce or retry the documented launch; pin that revision and include it in uv.lock.
AGENTS.md reference: AGENTS.md:L358-L363
Useful? React with 👍 / 👎.
Measure contact-conditioning and protein-length effects for the default exp277 step 266344 checkpoint on all 97 eval-val proteins, and compare MarinFold with original AFDB training structures and later biological monomers. Includes source CSVs, figures, a summary PDF, frozen execution bundles, raw predictions, and public checksummed archives.
All 6,664 eval-val contact-injection conditions / 666,400 rollouts and 600 corrected monomer rollouts are complete. Supplied contacts are removed from truth and prediction candidates, with matched unconditioned comparisons and protein-bootstrap intervals. Monomer selection checks exact retained training membership, original AFDB v4 contacts, later PDB release, coverage, biological assembly, and literature context. Crystal copies are distinguished from multichain biological assemblies. The monomer screen is limited and does not establish error-correction prevalence or behavior on severe AF2 fold failures.
Validation: 12 protocol/assembly-regression tests pass; 20 existing saved-vote comparisons exactly match the canonical evaluator. No token-cap hits occurred. Invalid-rollout sensitivity preserves the monomer conclusions. All six new inference markers match the frozen plan, worker, checkpoint identity, and H100 execution bundle. Anonymous access and all 313 members of the updated 16.97 MB public result archive were verified; the 97 eval-val raw-prediction bundles remain separately indexed and checksummed.
References #369.