Repository navigation
Conversation
Rename prefix_and_positions, fwd_matrix, pcontact_from_fwd, pcontact_matrix, pairwise_score_matrix, gt_contact_matrix and metric_rows to drop the leading underscore, so experiments (exp341's interpretability harness first) can import them without reaching into private helpers. No behaviour change. exp159 still imports the underscored names, but it pins marinfold to its own git branch (exp159-backtracking-corpus), so it is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the leading underscore from seven helpers in
marinfold/marinfold/document_structures/contacts_v1/inference.pyso experiments can import them as public API:prefix_and_positions,fwd_matrix,pcontact_from_fwd,pcontact_matrix,pairwise_score_matrix(the pairwise P(contact) readout)gt_contact_matrix,metric_rows(ground-truth matrix and per-range precision/AUC)_sym_from_fwdstays private; only the rollout tie-break uses it.No behaviour change. Callers in
inference.pyandtests/document_structures/contacts_v1/test_inference.pyare updated;uv run pytest tests/document_structures/contacts_v1/passes (253 passed, 4 skipped).Why: exp341 (#341) builds an interpretability harness whose metric is this readout, and its research plan (section 4.5) calls for promoting these names rather than importing private helpers from an experiment.
Not updated: exp159 still imports the underscored names, but its
pyproject.tomlpins marinfold to theexp159-backtracking-corpusgit branch, so this change does not reach it.🤖 Generated with Claude Code