Repository navigation
exp345: audit contact-map errors and 19,400 whole-map rollouts - #346
timodonnell wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @timodonnell's task in 9m 38s —— View job
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ca9a34868
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sys.path.insert(0, str(EXPERIMENTS / "exp89_evals_contacts_v1_model_on_eval_set")) | ||
| from compute_metrics import metric_rows, resolved_pairs, true_matrix |
There was a problem hiding this comment.
Move the shared scorer into an evals library
This makes exp345 another direct consumer of exp89's metric helpers by mutating sys.path; repo-wide search shows the same helpers are already reused by exp321, exp326, exp333, and others. Once a second experiment needs a helper, repository policy requires promoting it to the kind library, so the canonical scoring API should live in an evals package imported through an explicit path dependency rather than treating exp89 as a library.
AGENTS.md reference: AGENTS.md:L38-L42
Useful? React with 👍 / 👎.
🤖 Code reviewNo issues found. Checked for bugs and AGENTS.md compliance. Reviewed commit: |
Adds a reproducible contact-map audit of all 97 eval-val proteins using exp277 epoch 2, step 479417. The original offline atlas shows predicted and true maps, votes, errors and annotated cases. The follow-up saves 200 complete individual rollouts per protein and adds an offline viewer for all 19,400 maps, with sample selection, paired truth, synchronized zoom, error overlays, per-sample accuracy and CSV downloads.
The whole-map probe finds that selecting one sample does not improve mean accuracy even with a truth-informed oracle: pooled top-R F1 is 55.79%, versus 55.04% for the best of 200 (paired Δ −0.75 points, 95% interval −2.00 to +0.57). Pooled voting beats the best individual on 62/97 proteins. Average individual F1 is 41.53%; independent-pool consensus and mean-token-likelihood selectors score 48.95% and 46.73%. Severe failures remain poor in their individual maps, although 35 proteins have a better oracle sample. The report exposes those exceptions.
Independent-pool cluster voting is tied with pooled voting, but average-linkage Jaccard clustering mostly isolates outliers: only 37/194 k=4 fits have multiple eligible test clusters. This limits the modes interpretation. The writeup distinguishes observed map errors from unproven training causes and 3D feasibility.
Validation: all 19,400 rollouts terminated and passed raw-data integrity checks. Both independent 100-rollout pools reproduce saved all/long scores within 0.005. There are 582 exact comparisons against the canonical scorer, in addition to the original 1,940 source-score checks. Browser checks match every individual map in both ranges (38,800 scores) at desktop and mobile sizes and exercise every gallery map and control. Independent fixtures cover cardinality, emission order, a two-mode mixture and truth-independent selection. Ruff and diff checks pass. No eval-test data were read.
The run records per-protein timings, checkpoint/tokenizer identities, sampling seeds, source hashes and all execution attempts. Pure inference took 19.15 minutes on one H100. The in-region fp32→bf16 export verifies all 267 tensors and preserves the weights used by bf16 inference. Reports, raw maps, tables and figures are anonymously readable and checksum-verified; a clean-cache public download reproduced all samples.
Download the whole-map HTML report · All public artifacts. Small analysis artifacts and plots remain in git; the 17.5 MB HTML and 11.9 MB raw archive are published to the bucket.
Refs #345. Leave the experiment issue open for human follow-up.