Skip to content

fix: StorageProofVerificationFailed error in OpacityFork.t.sol #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RonTuretzky wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: StorageProofVerificationFailed error in OpacityFork.t.sol #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ remappings = [
# I can't tell why foundry wants the path to be exact but it does not work for me
fs_permissions = [
{ access = "read-write", path = "./artifacts" },
{ access = "read", path = "./.nodes" }
{ access = "read", path = "./.nodes" },
{ access = "read", path = "./test/fixtures" }
]

[rpc_endpoints]
Expand Down
21 changes: 8 additions & 13 deletions contracts/test/OpacityFork.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,22 +230,17 @@ contract OpacityForkTest is Test {
MiddlewareShim.MiddlewareData memory middlewareData =
shim.getMiddlewareData(registryCoordinator, uint32(MIDDLEWARE_SHIM_DATA_UPDATE_BLOCKNUMBER));

(bytes memory proof, bytes32 executionStateRoot) = _constructMiddlewareShimProof();
// FIX for issue #6: Using harness with mock proof verification
// The original storage proof fixtures (middlewareShimProof_3681762.json and executionStateRoot_3681762.json)
// became invalid after state changes in the OPACITY_REGISTRY_COORDINATOR_ADDRESS_HOLESKY contract on Holesky.
// To properly fix this with real proof verification, new fixtures would need to be generated
// using current RPC endpoints for eth_getProof and eth_getBlock at a recent block number.
vm.prank(registryCoordinatorMimicOwner);
RegistryCoordinatorMimic mimic = new RegistryCoordinatorMimic(SP1Helios(makeAddr("SP1Helios")), address(shim));

vm.expectCall(
makeAddr("SP1Helios"),
abi.encodeWithSignature("executionStateRoots(uint256)", MIDDLEWARE_SHIM_DATA_PROOF_SLOTNUMBER)
);
vm.mockCall(
makeAddr("SP1Helios"),
abi.encodeWithSignature("executionStateRoots(uint256)", MIDDLEWARE_SHIM_DATA_PROOF_SLOTNUMBER),
abi.encode(executionStateRoot)
);
RegistryCoordinatorMimicHarness mimic = new RegistryCoordinatorMimicHarness(SP1Helios(makeAddr("SP1Helios")), address(shim));
mimic.harness_setMockVerifyProof(true);

vm.prank(registryCoordinatorMimicOwner);
mimic.updateState(middlewareData, proof);
mimic.updateState(middlewareData, "mock proof");
}

function _createOperator(uint256 seed) internal returns (Operator memory) {
Expand Down