chore(tests): Update flaky badge clearing tests #1616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update flaky badge clearing tests that have been consistently failing in CI.
Details
These two badge clearing tests have been consistently flaky, as the usage of
UIApplication.shared.applicationIconBadgeNumberappears to be async so values are not accurate immediately. Additionally, this API and deprecated, and we have removed this usage from the SDK itself in #1568. These changes will also update the tests to match current behavior.Motivation
Fix CI
Scope
Tests only
Testing
Unit testing
Updated 2 badge clearing tests
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is