Skip to content

Web SDK Refactor: LoginOperationExecutor #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Conversation

fadi-george
Copy link
Contributor

@fadi-george fadi-george commented Apr 18, 2025

Description

1 Line Summary

Continuation of the Web SDK Refactor project.

Details

  • Implements LoginUserOperationExecutor
  • Ill make separate pr to implement PropertiesModel and SubscriptionsModel
  • Updated Model class to have generics , useful when using toJSON in the createSubscriptionsFromOperation method
  • Did not implement properties for SubscriptionObject like deviceOs, rooted, netType, and carrier, and appVersion

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable


Base automatically changed from fg/identity-rework to web-refractor April 18, 2025 21:56
const subs = { ...currentSubs };

if (subs[subscriptionId]) {
subs[subscriptionId] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could this just be subs[subscriptionId][id] = subscriptionId? Probably not a big deal but saves you a spread operator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clean it up in the tests pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this committed by mistake? Or is it going to be used in a future PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removing

@fadi-george fadi-george merged commit 266135c into web-refractor Apr 21, 2025
2 checks passed
@fadi-george fadi-george deleted the fg/login-exec branch April 21, 2025 18:45
@fadi-george fadi-george changed the title Web SDK Refactor: LoginOeprationExecutor Web SDK Refactor: LoginOperationExecutor Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants