-
Notifications
You must be signed in to change notification settings - Fork 376
Fix: NPE in SyncJobService since 5.4 #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
640e1e2 to
908126f
Compare
jkasten2
requested changes
Dec 4, 2025
OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/services/SyncJobService.kt
Show resolved
Hide resolved
135f6eb to
fc40248
Compare
jkasten2
requested changes
Dec 4, 2025
Member
jkasten2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, this PR address two 5.4.0 bugs then:
- Throwing on
onStopJob - Not closing the SyncJobService wakelock if the OneSignal initialization fails.
OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/services/SyncJobService.kt
Show resolved
Hide resolved
jkasten2
approved these changes
Dec 4, 2025
OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/services/SyncJobService.kt
Show resolved
Hide resolved
abdulraqeeb33
approved these changes
Dec 5, 2025
238a809 to
69e37a8
Compare
Contributor
Author
|
Addressed some flaky tests |
abdulraqeeb33
pushed a commit
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix NPE from SyncJobService introduced on 5.4.0 caused by incompleted / failed OneSignal initialization during onStartJob.
Details
Motivation
Address the new NPE introduced on 5.4.0.
Scope
After 5.4, onStartJob calls initWithContext in background. That introduced a small possibility when onStopJob is called before the initialization completes in the background. When that happens, OneSignal.getService will run into a NPE. In that case, we just need to omit the job and do not reschedule.
Testing
Unit testing
Add several test cases covering SyncJobService.kt
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is