Fix subscription/IAM not updated after upgrading from 5.2.0-beta or between 5.1.9 to 5.1.27 #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinliu9508
force-pushed
the
migration_recovery
branch
from
2f929ee to
405a778
Compare
18 tasks
jinliu9508
force-pushed
the
migration_recovery
branch
3 times, most recently
from
53dccfc to
25ff7b2
Compare
jinliu9508
changed the title
jkasten2
approved these changes
Mar 25, 2025
|
|
||
| import com.onesignal.debug.internal.logging.Logging | ||
|
|
||
| open class MigrationRecovery : IMigrationRecovery { |
There was a problem hiding this comment.
Let's make this an abstract class, as it isn't indented to be used directly, only extended.
There was a problem hiding this comment.
Good point! This was actually designed but was playing with it as a base class.
Comment on lines
6
to
16
| override fun isInBadState(): Boolean { | ||
| return false | ||
| } | ||
|
|
||
| override fun recover() { | ||
| // left blank intentionally | ||
| } | ||
|
|
||
| override fun recoveryMessage(): String { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
If this is made an abstract class then these 3 methods do not need to be defined here.
There was a problem hiding this comment.
I have updated the code and tested the change in the latest push.
jinliu9508
force-pushed
the
migration_recovery
branch
2 times, most recently
from
92344ee to
cfa6d8d
Compare
jkasten2
reviewed
Mar 26, 2025
Comment on lines
6
to
10
| abstract override fun isInBadState(): Boolean | ||
|
|
||
| abstract override fun recover() | ||
|
|
||
| abstract override fun recoveryMessage(): String |
There was a problem hiding this comment.
These lines don't need to be here at all, these all implied and the complier doesn't require them.
There was a problem hiding this comment.
Ok I have removed them in the latest push.
jinliu9508
force-pushed
the
migration_recovery
branch
from
cfa6d8d to
05fd286
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Added a MigrationRecovery that detects and recovers a bad state that push sub ID is missing in the config store, caused by a bug in 5.2.0-beta or any version between 5.1.9-5.1.27.
Details
Motivation
5.2.0-beta and all versions between 5.1.9-5.1.27 have a specific logic for push subscription that depends on the result of a remote params fetch. It may cause the push sub ID to be missing from the config model if a postCreateDelay bug also happens that the app is closed within 5 seconds of first start.
Scope
A new MigrationRecovery that will check the status of the config model store and the subscription model store at the start() level.
OPTIONAL - Other
Interface IMigrationRecovery and a base class MigrationRecovery are added for the ease of creating more recovery in the future.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
Step to reproduce:
Expected Behavior After the Fix:
After downgrade, the push subscription ID is correctly updated. All IAMs are displayed as expected.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is