Fix personal max record badge

[skaush21]

Description

Fixes:

1. Based on the current design documentation and schema, updated the Data Source to merge Time Entries and savedTangibleHrs to get an accurate reading on the personal best max hour.
2. Modified a date format that fixed the earned dates that were not being added.

Related PRS (if any):

Related backend PR: PR #947
To test this PR use frontend development.

Main changes explained:

• Fixed formatting issue, that was causing earnedDates to be inaccurate.
• optimized code, improved clarity, and reduced overhead calls.
• added a merge function to merge Time Entries and user.savedTangibleHrs
• cleaned up the code from debugging and uncommented the functioning code.

How to test:

1. check into the current branch
2. do npm install and ... to run this PR locally
3. Clear site data/cache
4. log in as admin user
5. go to dashboard→ Add Time via Add intangible Time Entry

• Use Postman to initiate a request
• Navigate to dashboard -> view Profile -> Featured Badges
• Verify that the New Personal Max Record Badge icon contains the current max hour
  Note: earnedDate will showcase the current date (Sunday) and not the previous dates, this is because user.savedTangibleHrs does not have any dates associated with its hours, whereas Time Entries does. Due to this, previous dates are not accounted for.
• add hours via userProfile -> savedTangibleHrs using MongoDB.
• Use Postman to send requests and verify in the front end that the personal best max hour has been updated with the new hour. Note: The personal best max hour takes the max hour overall weeks. Any hour added must be higher than any previous week.
• Additionally, verify that the badge appears in the badgeCollection using MongoDB. To do this, navigate to userProfile -> badgeCollection -> Object. Copy the badge ID within the Object and open a separate tab for the badges folder. Use the following in the search and paste the badge ID within the quotations. { _id: ObjectId("666b78265bca0bcb94080605") }.

Screenshots or videos of changes:

Modify the backend with the following to test this PR:

Verify

Note:

Will need to use Postman to POST and GET requests and MongoDB to update savedTangibleHrs and verify that the badge collection has the badge.

[kobakvantrishvili]

It's unclear to me how to test this PR. I don't know where exactly to modify the backend code and I'm also not sure what HTTP request I should send out. More clarity or a video demonstration would be good. I have no complaints with the actual code that's modified as it makes sense and is readable.

[jeyanthi-sm]

The Personal Max Record Badge is not awarded to my test email address after following those steps. I have attached the exact steps and the resulting output.

If the user has no badges or joined recently, then there won’t be any badges, and this loop won’t execute at all:

for (let i = 0; i < badgeCollection.length; i += 1) {
if (badgeCollection[i].badge?.type === 'Personal Max') {
As a result, the record for 'Personal Max' won’t be created.

The same situation applies to a new user with a default lastWeekTangibleHrs. In that case, this condition will fail:

user.lastWeekTangibleHrs &&
user.lastWeekTangibleHrs >= user.personalBestMaxHrs

Additionally, if badgeOfType is undefined, this line will result in an error:
badgeOfType.earnedDate.unshift(moment().format('MMM-DD-YYYY'));

[saigirishpabbathi]

Reviewed the PR but the personal max is not working as mentioned in the description. Also, instead of naming in a generic way please use appropriate method name like mergeHours or something feasible to you instead of mergeArrays.
Also do not add comments in the code.

Screen.Recording.2025-01-25.at.6.16.02.PM.mov