remove non-required post from the Host HTTP-header #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the HTTP-header `Host` ports are not required, even if you use HTTPS/TLS. _A Host header field must be sent in all HTTP/1.1 request messages. A 400 (Bad Request) status code may be sent to any HTTP/1.1 request message that lacks or contains more than one Host header field._ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host HTTP gateways/reverse proxies which evaluate Host-Headers to choose the correct "route" may not forward you to the actual service which causes the PoC fail with an `IndexError`: ``` DEBUG - Crafting socket DEBUG - Setting SSL context with verify mode False /home/user/tools/onapsis_icmad_scanner/src/./ICMAD_scanner.py:37: DeprecationWarning: ssl.SSLContext() without protocol argument is deprecated. context = ssl.SSLContext() /home/user/tools/onapsis_icmad_scanner/src/./ICMAD_scanner.py:37: DeprecationWarning: ssl.PROTOCOL_TLS is deprecated context = ssl.SSLContext() DEBUG - Wraping socket with SSL DEBUG - Connection established my-host:443 DEBUG - Validating resource /sap/admin/public/default.html?aaa DEBUG - Payload sent Traceback (most recent call last): File "/home/user/tools/onapsis_icmad_scanner/src/./ICMAD_scanner.py", line 220, in <module> main() File "/home/user/tools/onapsis_icmad_scanner/src/./ICMAD_scanner.py", line 196, in main resource = _validate_resource_and_cache(args.host, args.port, File "/home/user/tools/onapsis_icmad_scanner/src/./ICMAD_scanner.py", line 129, in _validate_resource_and_cache resp['responses'][0]['status_code']) IndexError: list index out of range ``` Could you consider to remove the port in line 118 if it isn't critical for the PoC to actually trigger the vulnerability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the HTTP-header
Hostports are not required, even if you use HTTPS/TLS.A Host header field must be sent in all HTTP/1.1 request messages. A 400 (Bad Request) status code may be sent to any HTTP/1.1 request message that lacks or contains more than one Host header field.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host
HTTP gateways/reverse proxies which evaluate Host-Headers to choose the correct "route" may not forward you to the actual service which causes the PoC fail with an
IndexError:Could you consider to remove the port in line 118 if it isn't critical for the PoC to actually trigger the vulnerability?