A button in the "post" tab that allows to set starting price and buyout price equally#19
Open
kennycrafty wants to merge 6 commits into
Open
Conversation
the checkbox should set the starting price to the buyout price by default when postion items. functional implementation still needs to be done.
public method contained the same code. now the public method calls the private method.
method to check general visibility of starting price input is established: update_start_price_visibility
if the checkbox "Starting = Buying" is checked, the check for "Unit Starting Price" > "Unit Buying Price" is not done anymore. Why? the checkbox "Starting = Buying" deactivates the usage of "Unit Starting Price"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add a checkbox to the "post" auctions tab. The button is unchecked by default.
Checking the button removes the "Starting price" input box and sets the "Starting price" of auctions to the "Buyout price". This sometimes saves the hustle of copying the buyout price and pasting it into the starting price.
The blocking behavior of the "Post" button in the "post" tab is deactivated on checking this box.
Checking will not persist after relogging/rebooting client. Probably possible to add, i was just too lazy to find the persistence store.