Skip to content

Conversation

@OhACD
Copy link
Owner

@OhACD OhACD commented Nov 20, 2025

Pull Request: Implement Magic Login System and User Account Management Features

Overview:
This pull request introduces a magic login system leveraging Django signing for token management, alongside essential user account features including registration, verification, and deletion processes.

Added Features:

  1. Magic Registration and Login:

    • Users can register and log in using their name and email via magic tokens.
    • Tokens are generated using Django's signing dumps for enhanced security.
  2. Token Management:

    • Login tokens expire after 30 minutes.
    • Email verification tokens expire after 24 hours.
    • Currently, multiple token requests are not managed for revocation; tokens will expire without revocation management.
  3. User Deletion Endpoint:

    • Implemented a secure endpoint for staff members to delete user accounts, ensuring only authorized personnel can perform this action.
  4. Email Verification:

    • Full email verification implemented using unique tokens for each action (login and verification) sent directly to the user's email.
  5. Core App Structure:

    • Main landing page, about section, and layout are integrated within the core application structure.
  6. Accounts App:

    • A separate accounts app has been created to manage user registration, deletion, and related functionalities.

Next Steps:

  • Post-testing of the core system to ensure all functionalities work as intended.
  • Further enhancements to the token management system, including potential revocation features to improve security.

Testing:

  • Ensure comprehensive test cases are in place for the magic login flow, including scenarios for token expiration and user deletion.

This pull request aims to establish a robust user authentication system while maintaining security standards. Feedback and suggestions for improvements are welcome!

@OhACD OhACD merged commit 63684ed into main Nov 20, 2025
1 check failed
@OhACD OhACD deleted the feature/magic_login branch November 21, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants