make Bridge pausable #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvladika
reviewed
Oct 26, 2023
yahgwai
reviewed
Oct 26, 2023
| @@ -66,6 +70,18 @@ abstract contract AbsBridge is Initializable, DelegateCallAware, IBridge { | |||
| } | |||
| _; | |||
| } | |||
| modifier whenNotPaused() { | |||
There was a problem hiding this comment.
I think it would be nice to have more granular pauses available in the bridge. Eg:
- pause withdrawal / outbox
- pause inbox / delayed messages (we already have this in the inbox contract so maybe we could remove it there and put it here instead)
- pause seq inbox messages
There was a problem hiding this comment.
As also mentioned here #74 (review)
we can use OZ AccessControl by having a BridgeStorage base contract that inherit the current storage layout so it doesn't get shifted downward.
|
closing in favor of #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pausing batch posting requires all batchPosters be removed in the sequencer inbox, pausing outbox execution requires all allowed outboxes be removed in the bridge, and pausing force inclusion isn't possible / requires a proxy upgrade. This makes those things possible more cleanly.