Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for Pectra Fork #420

Closed
wants to merge 2 commits into from
Closed

Conversation

tebraDev
Copy link

@tebraDev tebraDev commented Mar 7, 2025

merge of ethereum/go-ethereum@cd78b65

This resolves a situation on the Sepolia testnet, which has a different deposit contract. The contract on that network emits two kinds of logs, instead of only deposit events like the deposit contract on mainnet. So we need to skip events with mismatched topics.

Part of #418

This resolves a situation on the Sepolia testnet, which has a different
deposit contract. The contract on that network emits two kinds of logs,
instead of only deposit events like the deposit contract on mainnet. So
we need to skip events with mismatched topics.
Copy link

cla-bot bot commented Mar 7, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2025

CLA assistant check
All committers have signed the CLA.

@tebraDev tebraDev changed the title core: match on deposit contract log topic (#31317) Hotfix for Pectra Fork Mar 7, 2025
@tebraDev
Copy link
Author

tebraDev commented Mar 7, 2025

@eljobe @joshuacolvin0 @Tristan-Wilson can some of you review pls?

Copy link

cla-bot bot commented Mar 7, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@eljobe
Copy link
Member

eljobe commented Mar 11, 2025

Hey @tebraDev, thanks for the PR, but we're just planning to catch up with the upstream changes in go-ethereum. We'll pick this up when we pick up the 1.15.5 patch. It doesn't really affect nitro too much as we don't take deposits for consensus clients running on our network.

@eljobe eljobe closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants