Only log gas estimation error for assertion creation/confirmation if …

…persistent (#733)
OffchainLabs · Feb 26, 2025 · 996a463 · 996a463
1 parent ed22078
commit 996a463
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/assertions/confirmation.go b/assertions/confirmation.go
@@ -67,6 +67,7 @@ func (m *Manager) keepTryingAssertionConfirmation(ctx context.Context, assertion
 		return
 	}
 	exceedsMaxMempoolSizeEphemeralErrorHandler := ephemeral.NewEphemeralErrorHandler(10*time.Minute, "posting this transaction will exceed max mempool size", 0)
+	gasEstimationEphemeralErrorHandler := ephemeral.NewEphemeralErrorHandler(10*time.Minute, "gas estimation errored for tx with hash", 0)
 	ticker := time.NewTicker(m.times.confInterval)
 	defer ticker.Stop()
 	for {
@@ -98,6 +99,7 @@ func (m *Manager) keepTryingAssertionConfirmation(ctx context.Context, assertion
 				if !strings.Contains(err.Error(), "PREV_NOT_LATEST_CONFIRMED") {
 					logLevel := log.Error
 					logLevel = exceedsMaxMempoolSizeEphemeralErrorHandler.LogLevel(err, logLevel)
+					logLevel = gasEstimationEphemeralErrorHandler.LogLevel(err, logLevel)
 
 					logLevel("Could not confirm assertion", "err", err, "assertionHash", assertionHash.Hash)
 					errorConfirmingAssertionByTimeCounter.Inc(1)

diff --git a/assertions/poster.go b/assertions/poster.go
@@ -37,6 +37,7 @@ func (m *Manager) postAssertionRoutine(ctx context.Context) {
 	}
 
 	exceedsMaxMempoolSizeEphemeralErrorHandler := ephemeral.NewEphemeralErrorHandler(10*time.Minute, "posting this transaction will exceed max mempool size", 0)
+	gasEstimationEphemeralErrorHandler := ephemeral.NewEphemeralErrorHandler(10*time.Minute, "gas estimation errored for tx with hash", 0)
 
 	log.Info("Ready to post")
 	ticker := time.NewTicker(m.times.postInterval)
@@ -51,6 +52,7 @@ func (m *Manager) postAssertionRoutine(ctx context.Context) {
 			default:
 				logLevel := log.Error
 				logLevel = exceedsMaxMempoolSizeEphemeralErrorHandler.LogLevel(err, logLevel)
+				logLevel = gasEstimationEphemeralErrorHandler.LogLevel(err, logLevel)
 
 				logLevel("Could not submit latest assertion", "err", err, "validatorName", m.validatorName)
 				errorPostingAssertionCounter.Inc(1)

diff --git a/challenge-manager/chain-watcher/watcher.go b/challenge-manager/chain-watcher/watcher.go
@@ -882,6 +882,7 @@ func (w *Watcher) confirmAssertionByChallengeWinner(ctx context.Context, edge pr
 	)
 
 	exceedsMaxMempoolSizeEphemeralErrorHandler := ephemeral.NewEphemeralErrorHandler(10*time.Minute, "posting this transaction will exceed max mempool size", 0)
+	gasEstimationEphemeralErrorHandler := ephemeral.NewEphemeralErrorHandler(10*time.Minute, "gas estimation errored for tx with hash", 0)
 
 	// Compute the number of blocks until we reach the assertion's
 	// deadline for confirmation.
@@ -903,6 +904,7 @@ func (w *Watcher) confirmAssertionByChallengeWinner(ctx context.Context, edge pr
 			if err != nil {
 				logLevel := log.Error
 				logLevel = exceedsMaxMempoolSizeEphemeralErrorHandler.LogLevel(err, logLevel)
+				logLevel = gasEstimationEphemeralErrorHandler.LogLevel(err, logLevel)
 
 				logLevel("Could not confirm assertion", "err", err, "assertionHash", claimedAssertion)
 				errorConfirmingAssertionByWinnerCounter.Inc(1)