fix: redeem teleport error #2321
Open
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dewanshparashar
commented
Mar 10, 2025
| @@ -63,17 +63,17 @@ export const getDepositStatus = ( | |||
| } | |||
|
|
|||
| if (isTeleportTx(tx)) { | |||
There was a problem hiding this comment.
Only in the case of Teleport txns, we access l1ToL2MsgData
dewanshparashar
changed the title
douglance
previously approved these changes
Mar 10, 2025
chrstph-dvx
reviewed
Mar 10, 2025
chrstph-dvx
approved these changes
Mar 10, 2025
douglance
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of a refactor where we renamed deposit transactions'
l1ToL2MsgDatatoparentToChildMsgDatain all deposit transactions, however, we rolled it back partially for Teleport cases since they have 2 legs and L1, L2, L3 terminologies still make sense in them.So the logic is - use
parentToChildMsgDatafor normal deposits, and usel1ToL2MsgData + l2ToL3MsgDatafor teleport txns.During a failed teleport redemption flow, there was a mixup and we not correctly populating
l1ToL2MsgDatahence the failure to find the retryable-ticket-id. This PR fixes that.