Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ETH transfers custom native token chains part 2 #2274

Draft
wants to merge 2 commits into
base: eth-custom-orbit-1
Choose a base branch
from

Conversation

brtkx
Copy link
Contributor

@brtkx brtkx commented Feb 24, 2025

Only wrapping and deposit logic. UI not adjusted like summary panel, dialog content, etc.

@cla-bot cla-bot bot added the cla-signed label Feb 24, 2025
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-token-bridge ✅ Ready (Inspect) Visit Preview Feb 24, 2025 11:25am

@@ -1144,6 +1237,10 @@ export function TransferPanel() {
if (isCctpTransfer) {
return transferCctp()
}
if (isDepositMode && nativeCurrency.isCustom && isSelectedTokenEther) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can abstract this into it's own function which can be reused to identify the transfer case that is being implemented in these set of PRs.
isEthTransferToCustomNativeCurrencyChain(), and it's corresponding hook.

This flag can also be used in other places to show different UI case by case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants