Streamline sub-agents#582
Merged
Merged
Conversation
OisinKyne
pushed a commit
that referenced
this pull request
Jun 3, 2026
Addresses review findings #1/#2/#3 on PR #582 "Streamline sub-agents". - agentcrd: document the SeedHostFiles "sub-agents-for-sale only" contract and add TestMarkerOnlyWrittenBySeedHostFiles, locking that the .no-bundled-skills marker is written only by SeedHostFiles and never by the reusable seed primitives (WriteSoul, embed.WriteSkillSubset) a master or objective-only path could route through. [finding #2] - serviceoffercontroller: lower the rendered terminal.timeout 180 -> 80 so a single operation can no longer outlive the 90s lifetime_seconds session; the render test now parses both and asserts timeout <= lifetime_seconds. [finding #3] - agentcrd: add a //go:build integration test that deploys a real CRD sub-agent and verifies the Hermes image honors the contract end-to-end: the marker on the PVC and visible in-pod, the capped hermes-config keys (lifetime_seconds/max_turns/reasoning_effort/disabled_toolsets), and a behavioral bundled-skills-skipped signal. Skips gracefully without a cluster. [finding #1] - plans/sell-agent-perf.md: post-review hardening section and corrected measured figures (SOUL.md 2128 -> 1460 bytes ~370 tok; 177 addresses preserved across 8 reference files).
Addresses review findings #1/#2/#3 on PR #582 "Streamline sub-agents". - agentcrd: document the SeedHostFiles "sub-agents-for-sale only" contract and add TestMarkerOnlyWrittenBySeedHostFiles, locking that the .no-bundled-skills marker is written only by SeedHostFiles and never by the reusable seed primitives (WriteSoul, embed.WriteSkillSubset) a master or objective-only path could route through. [finding #2] - serviceoffercontroller: lower the rendered terminal.timeout 180 -> 80 so a single operation can no longer outlive the 90s lifetime_seconds session; the render test now parses both and asserts timeout <= lifetime_seconds. [finding #3] - agentcrd: add a //go:build integration test that deploys a real CRD sub-agent and verifies the Hermes image honors the contract end-to-end: the marker on the PVC and visible in-pod, the capped hermes-config keys (lifetime_seconds/max_turns/reasoning_effort/disabled_toolsets), and a behavioral bundled-skills-skipped signal. Skips gracefully without a cluster. [finding #1] - plans/sell-agent-perf.md: post-review hardening section and corrected measured figures (SOUL.md 2128 -> 1460 bytes ~370 tok; 177 addresses preserved across 8 reference files).
OisinKyne
force-pushed
the
oisin/sell-agent-streamline
branch
from
fe47093 to
df5bc34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes a pass at lowering the overhead of sub-agents, to ensure they use less tokens and respond within the 100s cap.