-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Port MASTG-TEST-0033: Native code Exposed Through WebViews #3494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…text traffic and JavaScript bridges
…test failure conditions
…d enhance MASTG-BEST-0012 documentation
…d enhance MASTG-BEST-0012 documentation Base on discussion OWASP#2425
…improve HTML structure
… regarding WebView security risks
…dditional findings
| - pattern: $WEBVIEW.addJavascriptInterface($BRIDGE, $NAME) | ||
| - pattern: "@JavascriptInterface $RETURN_TYPE $FUNCTION (...){...}" No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to match the whole Bridge class with a pattern like the following, but without much success
patterns:
- pattern: $_.addJavascriptInterface(new $BRIDGE (...), $_)
- pattern: class $BRIDGE { ... }|
@cpholguera @sushi2k Can you please assign the review to me. |
| ## Steps | ||
|
|
||
| 1. Use a tool like @MASTG-TOOL-0110 to search for references to: | ||
| - `usesCleartextTraffic` option in the AndroidManifest.xml file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be irrelevant for the specific purpose of this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasoning is at L15
The weakness could become a vulnerability if the WebView allows unencrypted (non-TLS) traffic (i.e., HTTPS) in combination with an XSS attack.
We could narrow the scope to "focus only on the bridges" and point to MASTG-TEST-0235 for confidentiality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be better, I think. Data can be exfiltrated even through secure connections.
…nd clarify observation steps
|
@ScreaMy7 we will once it's ready for review. For now it's still in DRAFT. Thank you! |
This PR closes #2977
Description
Migration to v2.
TODOS
@JavascriptInterfaceto add in the rule