#3379 Update 0x04g-Testing-Cryptography.md #3385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saw your comment about opening after merging. I’ll keep it closed for now. |
|
This is currently in draft state awaiting #3199 |
|
Please pull the latest master and resolve any conflicts. Thanks! |
|
completly forgot about this one. I'll clean it up now and have a look at the comments on #3379 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cryptography testing documentation to provide more comprehensive guidance on key derivation functions (KDFs) and improper random number generation. The changes expand the existing content with detailed explanations and best practices.
Key Changes:
- Significantly expanded the "Improper Key Derivation Functions" section with detailed explanations of KDF types and use cases
- Added comprehensive guidance on choosing appropriate KDFs for different scenarios (cryptographic vs password storage)
- Enhanced the "Improper Random Number Generation" section with clearer explanations of CSPRNGs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Diolor
suggested changes
Oct 30, 2025
Co-authored-by: Dionysis Lorentzos <[email protected]>
Co-authored-by: Dionysis Lorentzos <[email protected]>
Clarified the role of Key Derivation Functions (KDFs) in cryptography, emphasizing their importance for both key generation and password storage. Added recommendations for selecting and implementing KDFs, including the use of secure hash functions and appropriate iteration counts.
Clarified recommendations for using KDFs and password hashing algorithms, including iteration counts and suitable algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3199
Description
Please see discussions under #3199
[x] I have read the contributing guidelines.
Guidelines for Pull Requests (you can delete this section after reading):