docs(contributing): document advisory DB setup for full test suite - #1041
Merged
sonukapoor merged 1 commit intoAug 23, 2026
Merged
Conversation
sonukapoor
approved these changes
Aug 23, 2026
sonukapoor
left a comment
sonukapoor
left a comment
Collaborator
There was a problem hiding this comment.
Accurate and helpful - the five-step sequence matches CI exactly, and the explanation of why advisories sync has to run before npm test saves the next contributor from a confusing partial failure. Merging.
Collaborator
|
Merged - thank you @luojiyin1987! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1040
Summary
npm test,npm run build) with the five-step sequence from.github/workflows/ci.yml.advisories syncruns beforenpm test: e2e tests that scan with--offlineread the local advisory database. Without the sync, those tests fail while the rest of the suite passes.Docs only. No code or test changes (+12/-2 in CONTRIBUTING.md).