Skip to content

fix: improve flag validation guidance - #1022

Merged
sonukapoor merged 1 commit into
OWASP:mainfrom
Anikesh348:feature/issue-401-flag-guidance
Aug 24, 2026
Merged

sonukapoor merged 1 commit into
OWASP:mainfrom
Anikesh348:feature/issue-401-flag-guidance

Conversation

@Anikesh348

Copy link
Copy Markdown

What changed and why

I expanded flag validation errors with actionable alternatives and made the --create-pr/--json guidance reachable. I also added exact message assertions and coverage for the remaining --create-pr and --base relationships.

Verification

  • npm test -- --runInBand tests/validate.test.ts (29 tests passed)
  • npm test -- --runInBand (114 suites, 1,449 tests passed)
  • npm run build
  • git diff --check

Limitations

No formatter command is defined in package.json, so I did not run a separate formatter.

Closes #401

@Anikesh348
Anikesh348 requested a review from sonukapoor as a code owner August 20, 2026 14:45

@sonukapoor sonukapoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvement - all the flag validation messages now tell you what to do next rather than just what went wrong, the new --create-pr dependency checks are comprehensive, and the test coverage covers both the new and existing checks. Closes #401. Merging.

@sonukapoor sonukapoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix - clearer guidance makes a real difference for contributors hitting flag conflicts.

@sonukapoor
sonukapoor merged commit 2748d82 into OWASP:main Aug 24, 2026
6 checks passed
@sonukapoor

Copy link
Copy Markdown
Collaborator

Merged - thank you @Anikesh348!

@Anikesh348

Copy link
Copy Markdown
Author

Thank you for the review and merge! Glad I could contribute.

@sonukapoor sonukapoor mentioned this pull request Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: incompatible flag errors should explain which option to use, not just state the conflict

2 participants