Skip to content

feat: link package names to npm in html report #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonukapoor merged 6 commits into from
Aug 24, 2026
Merged

feat: link package names to npm in html report #1021

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd43fe3
feat: link package names to npm in html report
bharatmalik-cs Aug 20, 2026
6d650c7
Made all the required changes
bharatmalik-cs Aug 20, 2026
ba6126f
fix: link all dependency path nodes
bharatmalik-cs Aug 20, 2026
24b2ca7
fix : review changes were addressed
bharatmalik-cs Aug 21, 2026
d34726f
fix: use encodeURIComponent for npm links, drop unused import
bharatmalik-cs Aug 22, 2026
328074b
Merge branch 'main' into fix/npm-links-in-report
bharatmalik-cs Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/output/html-reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type { OverrideFinding } from "../overrides/types.js";
import type { MaintenanceFinding } from "../maintenance/types.js";
import { UNVERIFIED_PARENT_UPGRADE_NOTE, type SuggestedFixCommandPlan } from "../remediation/fix-commands.js";
import { getCompletenessImpact } from "../scan/completeness.js";
import { escape } from "node:querystring";

@sonukapoor sonukapoor Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is unused - escape from node:querystring is never called anywhere in the file. Remove it (it will also fail the build if noUnusedLocals is enabled).


export type SerializedFinding = ReturnType<typeof serializeHtmlFinding>;

Expand Down Expand Up @@ -564,11 +565,11 @@ export function renderFindingRow(finding: SerializedFinding, idx: number, skippe
: `<span class="fix-hint none" title="No known fix — consider replacing this package">⚠ No fix</span>`;

const depPathHtml = finding.dependencyPaths.length > 0
? finding.dependencyPaths[0].map((node, i, arr) => {
const isLast = i === arr.length - 1;
return `<span class="dep-node${isLast ? " vulnerable" : ""}">${escapeHtml(node)}</span>${isLast ? "" : '<span class="dep-arrow">→</span>'}`;
}).join("")
: `<span class="dep-node">${escapeHtml(finding.package)}</span>`;
? finding.dependencyPaths[0].map((node, i, arr) => {
const isLast = i === arr.length - 1;
return `<a href="https://www.npmjs.com/package/${encodeURIComponent(node)}" target="_blank" rel="noopener noreferrer" class="dep-node${isLast ? " vulnerable" : ""}">${escapeHtml(node)}</a>${isLast ? "" : '<span class="dep-arrow">→</span>'}`;
}).join("")
: `<span class="dep-node">${escapeHtml(finding.package)}</span>`;

@sonukapoor sonukapoor Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .join("") - .map() returns an Array, and when you interpolate it into the template string it joins with commas by default. Add .join("") after the closing }).

const description = finding.vulnerabilities[0]?.summary ?? "";
const runnable = finding.runnableFixCommand ?? null;
Expand All @@ -586,10 +587,9 @@ export function renderFindingRow(finding: SerializedFinding, idx: number, skippe
const rootDepsHtml = finding.rootDependencies.length > 0
? finding.rootDependencies.map(name => `<span class="root-dep">${escapeHtml(name)}</span>`).join(", ")

@sonukapoor sonukapoor Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pkg-name cell link uses escapeHtml() in the href, but it should use encodeURIComponent() - same as you're doing for dep path nodes above. escapeHtml converts & to &amp; which breaks the URL. For scoped packages like @babel/core this would produce href="https://www.npmjs.com/package/@babel/core" correctly by accident, but the right function for URL encoding is encodeURIComponent:

<a href="https://www.npmjs.com/package/${encodeURIComponent(finding.package)}" ...>

: `<span class="root-dep-none">-</span>`;

return ` <tr id="row-${idx}" data-skipped="${isSkipped ? '1' : '0'}" onclick="toggleRow(${idx})">
return `<tr id="row-${idx}" data-skipped="${isSkipped ? '1' : '0'}" onclick="toggleRow(${idx})">
<td><span class="expand-icon" id="icon-${idx}">▶</span></td>
<td><div class="pkg-name">${escapeHtml(finding.package)}</div><div class="pkg-version">${escapeHtml(finding.version)}</div></td>
<td><div class="pkg-name"><a href="https://www.npmjs.com/package/${escapeHtml(finding.package)}" target="_blank" rel="noopener noreferrer">${escapeHtml(finding.package)}</a></div><div class="pkg-version">${escapeHtml(finding.version)}</div></td>
<td>${fixHtml}</td>
<td><span class="sev-badge ${escapeHtml(finding.severity)}">${escapeHtml(finding.severity)}</span></td>
<td>${renderRelBadge(finding)}</td>
Expand Down Expand Up @@ -842,7 +842,7 @@ export function renderFixPlan(plan: SuggestedFixCommandPlan | null): string {
: "";
const chainProofHtml = t.chainProof && t.chainSafeVersion
? (() => {
const hops = t.chainProof.map(h => `${escapeHtml(h.name)}@${escapeHtml(h.version)}`);
const hops = t.chainProof.map(h => `<a href="https://www.npmjs.com/package/${escapeHtml(h.name)}" target="_blank" rel="noopener noreferrer">${escapeHtml(h.name)}</a>@${escapeHtml(h.version)}`);
const safe = escapeHtml(t.chainSafeVersion);
const proofText = hops.length > 0
? `resolves via ${hops.join(" -&gt; ")} -&gt; ${safe} (safe)`
Expand Down