Use correct DB URI under docker-compose #210
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is against
feature/187
rather thanmaster
. The issue exists in both branches, but it only causes CI failures infeature/187
. I feel that makes it a "nice to have" inmaster
, but high priority in this branch.Currently the three jobs in
feature/187
CI builds all connect to the same mongolab URI. Only one job in each build can succeed; the others will fail the signup spec because the "new user" already exists in the database.This change updates the docker-compose configuration to set the
MONGODB_URI
env var. That makes the web service connect to the mongo service (in the other container) rather than the default mongolab URI.It also propagates
NODE_ENV
from the environment where docker-compose is run into the web container. That means the web service uses the appropriate config instead of always using development.This should make the CI builds in this branch as reliable those in
master
. There's still one other issue that needs fixing to make it fully reliable, see #159 for further details.