tests: add test coverage for ParameterMap failure_reasons and quality…....#127
Open
karnam-ui wants to merge 1 commit intoOSIPI:mainfrom
Open
tests: add test coverage for ParameterMap failure_reasons and quality…....#127karnam-ui wants to merge 1 commit intoOSIPI:mainfrom
karnam-ui wants to merge 1 commit intoOSIPI:mainfrom
Conversation
Author
|
I used AI assistance to help me understand the codebase structure and the correct ParameterMap constructor arguments, but I wrote and debugged these tests myself. Initially the tests failed because I was passing 1D arrays — I read the DataValidationError output and fixed the shape to 3D based on looking at the existing test_maps.py file which uses np.random.rand(64, 64, 20). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126
Adds unit tests for ParameterMap covering which covers-
failure_reasons is None by default
failure_reasons correctly stores per-voxel diagnostic strings
Passing voxels have empty string as failure reason
quality_mask shape matches values shape
Mismatched shapes raise an error
Tests expose the current gap where failure_reasons is declared but never popuateted,