r.pack: Replace traceback by error message for output issues #6346
+182
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for issues with the output file parent directory, and report error messages. This avoids a traceback originating at the very end of the tool execution when calling shutil.move. This adds tests for the newly handled error states as well as for other issues with the inputs. It adds the new pytest fixtures to scripts conftest.py file given there is at least some potential for reusability for similar simple tests.
github-actions
bot
added
raster
petrasovaa
previously approved these changes
Sep 17, 2025
petrasovaa
reviewed
Sep 23, 2025
petrasovaa
previously approved these changes
Sep 23, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…indows CI, this does not cause r.pack to fail. Assuming here that the directory still allows writes, we can't fully set up the test, so we don't test that for Windows.
|
The test with read-only directory would fail on Windows, so I'm skipping it for Windows. |
petrasovaa
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for issues with the output file parent directory, and report error messages. This avoids a traceback originating at the very end of the tool execution when calling shutil.move.
This adds tests for the newly handled error states as well as for other issues with the inputs.
It adds the new pytest fixtures to scripts conftest.py file given there is at least some potential for reusability for similar simple tests.